linux-kernel - Re: [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2014 07:38:55 -0800
From:	Benson Leung <bleung@...omium.org>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	Benson Leung <bleung@...gle.com>,
	Dudley Du <dudley.dulixin@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware
 update function support

On Tue, Dec 16, 2014 at 10:48 PM, Jeremiah Mahler <jmmahler@...il.com> wrote:
> So DESIGNWARE_PCI isn't required for all devices.  But if MOUSE_CYAPA is
> enabled some devices won't work unless I2C_DESIGNWARE_PCI is enabled.  I
> wonder if MOUSE_CYAPA should be broken up in to separate working
> configurations?  MOUSE_CYAPA_GEN5, MOUSE_CYAPA_GEN3, ?

Splitting into two configs doesn't help either. Currently, all Cypress
devices available for Chromebooks are Gen 3. This includes the ARM
Samsung Chromebook which doesn't use I2C_DESIGNWARE_PCI, and the
C720/HP Chromebook 14/Dell Chromebook 11 which do require
I2C_DESIGNWARE_PCI.

The right thing to do would be to add the the I2C_DESIGNWARE_PCI
depend for the CHROMEOS_LAPTOP config. The chromeos_laptop driver
actually refers to I2C_DESIGNWARE_PCI by name, so it is appropriate
there.

-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@...omium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/