linux-kernel - Re: [PATCH] scsi: arm: cumana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Dec 2014 08:50:45 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Finn Thain <fthain@...egraphics.com.au>,
	Michael Schmitz <schmitzmic@...il.com>,
	Russell King <linux@....linux.org.uk>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: arm: cumana_1.c:  Remove unused function

On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote:
> Remove the function cumanascsi_setup() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/scsi/arm/cumana_1.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c
> index 8ef810a..7c90d9c 100644
> --- a/drivers/scsi/arm/cumana_1.c
> +++ b/drivers/scsi/arm/cumana_1.c
> @@ -38,10 +38,6 @@
>  
>  #include "../NCR5380.h"
>  
> -void cumanascsi_setup(char *str, int *ints)
> -{
> -}
> -
>  const char *cumanascsi_info(struct Scsi_Host *spnt)
>  {
>  	return "";
[...]

You can blame Linus for this one :-)

~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c 
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void
cumanascsi_setup(char *str, int *ints)
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) {
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) }
~/linux-next$

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/