lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Dec 2014 21:46:35 -0500 (EST) From: Ben Skeggs <bskeggs@...hat.com> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: David Airlie <airlied@...ux.ie>, Alexandre Courbot <acourbot@...dia.com>, Ilia Mirkin <imirkin@...m.mit.edu>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] gpu: drm: nouveau: core: subdev: clock: base.c: Remove unused function ----- Original Message ----- > From: "Rickard Strandqvist" <rickard_strandqvist@...ctrumdigital.se> > To: "David Airlie" <airlied@...ux.ie>, "Ben Skeggs" <bskeggs@...hat.com> > Cc: "Rickard Strandqvist" <rickard_strandqvist@...ctrumdigital.se>, "Alexandre Courbot" <acourbot@...dia.com>, "Ilia > Mirkin" <imirkin@...m.mit.edu>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org > Sent: Sunday, 21 December, 2014 2:54:16 AM > Subject: [PATCH] gpu: drm: nouveau: core: subdev: clock: base.c: Remove unused function > > Remove the function nouveau_clock_astate() that is not used anywhere. No, don't remove this. It's only not used because noone got around to finishing load-based reclocking yet. NVIDIA has an implementation for the GK20A in the works that uses it. Ben. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > --- > drivers/gpu/drm/nouveau/core/include/subdev/clock.h | 1 - > drivers/gpu/drm/nouveau/core/subdev/clock/base.c | 10 ---------- > 2 files changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/core/include/subdev/clock.h > b/drivers/gpu/drm/nouveau/core/include/subdev/clock.h > index 36ed035..8577945 100644 > --- a/drivers/gpu/drm/nouveau/core/include/subdev/clock.h > +++ b/drivers/gpu/drm/nouveau/core/include/subdev/clock.h > @@ -159,7 +159,6 @@ int nva3_clock_pll_calc(struct nouveau_clock *, struct > nvbios_pll *, > int clk, struct nouveau_pll_vals *); > > int nouveau_clock_ustate(struct nouveau_clock *, int req, int pwr); > -int nouveau_clock_astate(struct nouveau_clock *, int req, int rel); > int nouveau_clock_dstate(struct nouveau_clock *, int req, int rel); > int nouveau_clock_tstate(struct nouveau_clock *, int req, int rel); > > diff --git a/drivers/gpu/drm/nouveau/core/subdev/clock/base.c > b/drivers/gpu/drm/nouveau/core/subdev/clock/base.c > index e51b72d..b2c852a 100644 > --- a/drivers/gpu/drm/nouveau/core/subdev/clock/base.c > +++ b/drivers/gpu/drm/nouveau/core/subdev/clock/base.c > @@ -430,16 +430,6 @@ nouveau_clock_ustate(struct nouveau_clock *clk, int req, > int pwr) > } > > int > -nouveau_clock_astate(struct nouveau_clock *clk, int req, int rel) > -{ > - if (!rel) clk->astate = req; > - if ( rel) clk->astate += rel; > - clk->astate = min(clk->astate, clk->state_nr - 1); > - clk->astate = max(clk->astate, 0); > - return nouveau_pstate_calc(clk, true); > -} > - > -int > nouveau_clock_tstate(struct nouveau_clock *clk, int req, int rel) > { > if (!rel) clk->tstate = req; > -- > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists