linux-kernel - Re: [PATCH] mmc: core: stop trying to switch width when only one bit is supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Dec 2014 10:58:23 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Chris Ball <chris@...ntf.net>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH] mmc: core: stop trying to switch width when only one bit
 is supported

On 17 December 2014 at 19:32, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> mmc_select_bus_width() will try to switch to MMC_BUS_WIDTH_4 even if
> MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA are not set in host->caps.
> Return as soon as possible when those flags are not set
>
> Fixes: 577fb13199b11d8cd75609183649be4b5561243f (mmc: rework
> selection of bus speed mode)
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Cc: <stable@...r.kernel.org> # 3.17

Thanks! Applied for fixes.

Kind regards
Uffe

> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 02ad79229f65..7466ce098e60 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -886,7 +886,7 @@ static int mmc_select_bus_width(struct mmc_card *card)
>         unsigned idx, bus_width = 0;
>         int err = 0;
>
> -       if (!mmc_can_ext_csd(card) &&
> +       if (!mmc_can_ext_csd(card) ||
>             !(host->caps & (MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA)))
>                 return 0;
>
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/