linux-kernel - Re: [PATCH] incorrect use of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Dec 2014 14:01:57 -0500
From:	Prarit Bhargava <prarit@...hat.com>
To:	Nicholas Mc Guire <der.herr@...r.at>
CC:	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] incorrect use of init_completion fixup



On 12/23/2014 12:52 PM, Nicholas Mc Guire wrote:
> The successive init_completion calls should be reinit_completion here.
> 

Hi Nicholas,

I know enough about this code to break it ;) ... what condition did you hit that
led you to this patch?

P.

> patch is against 3.18.0 linux-next
> 
> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> ---
>  drivers/dma/ioat/dma_v3.c |    4 +-
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> index 32eae38..3dbcc42 100644
> --- a/drivers/dma/ioat/dma_v3.c
> +++ b/drivers/dma/ioat/dma_v3.c
> @@ -1353,7 +1353,7 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device)
>  	}
> 
>  	async_tx_ack(tx);
> -	init_completion(&cmp);
> +	reinit_completion(&cmp);
>  	tx->callback = ioat3_dma_test_callback;
>  	tx->callback_param = &cmp;
>  	cookie = tx->tx_submit(tx);
> @@ -1405,7 +1405,7 @@ static int ioat_xor_val_self_test(struct ioatdma_device *device)
>  	}
> 
>  	async_tx_ack(tx);
> -	init_completion(&cmp);
> +	reinit_completion(&cmp);
>  	tx->callback = ioat3_dma_test_callback;
>  	tx->callback_param = &cmp;
>  	cookie = tx->tx_submit(tx);
> --
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/