| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Dec 2014 13:23:08 +0100 From: Sedat Dilek <sedat.dilek@...il.com> To: Nicholas Mc Guire <der.herr@...r.at> Cc: LKML <linux-kernel@...r.kernel.org>, linux-next <linux-next@...r.kernel.org> Subject: Re: [PATCH] fix handling of wait_for_completion_timeout result [ Not sure which persons and MLs you CCed - I am reading LKML offline ] Hi, your patch needs some refreshing... First your Subject... add a subject-prefix like... $ git format-patch --subject-prefix="next-20141226" [ The subject-prefix won't be seen if you push out the commit, but is good for people to see very quickly against WTF-tree you did your fixing. ] Your label... Check the log in [1] to path/to/file2change, this will tell it to you... $ git log --oneline drivers/i2c/busses/i2c-imx.c So your label should be better... i2c: imx: fix handling of wait_for_completion_timeout result Seems to be a quick hack :-), some typos in your commit-message... "wati_for_completion_timeout does not return negative values so "result" handlin here should be simplified to cover the actually possible cases only." *wait*_for_completion_timeout handlin*g* Hope this encourages you to do a v2. Have more fun! - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/i2c/busses/i2c-imx.c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists