linux-kernel - Re: [PATCH] srcu: Isolate srcu sections using CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Dec 2014 11:03:24 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com (supporter:S390),
	Lai Jiangshan <laijs@...fujitsu.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Josh Triplett <josh@...htriplett.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Anton Blanchard <anton@...ba.org>,
	Scott Wood <scottwood@...escale.com>,
	Andy Fleming <afleming@...escale.com>,
	Tiejun Chen <tiejun.chen@...driver.com>,
	Daniel Walter <dwalter@...gle.com>,
	Jens Freimann <jfrei@...ux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	linuxppc-dev@...ts.ozlabs.org (open list:LINUX FOR POWERPC...),
	linux-kernel@...r.kernel.org (open list),
	linux-s390@...r.kernel.org (open list:S390)
Subject: Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

On Sat, 27 Dec 2014 12:17:43 -0500
Pranith Kumar <bobby.prani@...il.com> wrote:

> @@ -65,10 +65,13 @@
>  #include <asm/kexec.h>
>  #include <asm/mmu_context.h>
>  #include <asm/code-patching.h>
> -#include <asm/kvm_ppc.h>
>  #include <asm/hugetlb.h>
>  #include <asm/epapr_hcalls.h>
> 
> +#if IS_ENABLED(CONFIG_KVM)
> +#include <asm/kvm_ppc.h>
> +#endif
> +
>  #ifdef DEBUG
>  #define DBG(fmt...) udbg_printf(fmt)
>  #else

I always cringe when I see an include protected by an #ifdef.
Is this really necessary? All that is done in asm-offsets.c is
to calculate offsets, the code where the two offsets in question
are used (entry64.S) does have the #ifdef for CONFIG_KVM.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/