linux-kernel - Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Dec 2014 19:04:35 -0800
From:	Serguey Parkhomovsky <sergueyparkhomovsky@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	HPDD-discuss@...ts.01.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about
 static declaration

On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
> 
> If you look at the source code just below these functions you will find:
> 
> EXPORT_SYMBOL(libcfs_arch_init);
> EXPORT_SYMBOL(libcfs_arch_cleanup);
> 
> So making these static is incorrect because they are being used outside
> of this file.
> 

Thanks for the review, and sorry about the noise; I'll be more careful next time.

Serguey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/