lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu,  1 Jan 2015 20:24:14 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	devel@...ica.org, linux-kernel@...r.kernel.org
Subject: [PATCH] acpi: acpica: utuuid:  Remove unused function

Remove the function acpi_ut_convert_string_to_uuid() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
---
 drivers/acpi/acpica/acutils.h |    5 -----
 drivers/acpi/acpica/utuuid.c  |   29 -----------------------------
 2 files changed, 34 deletions(-)

diff --git a/drivers/acpi/acpica/acutils.h b/drivers/acpi/acpica/acutils.h
index 486d342..18b82cd 100644
--- a/drivers/acpi/acpica/acutils.h
+++ b/drivers/acpi/acpica/acutils.h
@@ -782,9 +782,4 @@ int acpi_ut_file_vprintf(ACPI_FILE file, const char *format, va_list args);
 int acpi_ut_file_printf(ACPI_FILE file, const char *format, ...);
 #endif
 
-/*
- * utuuid -- UUID support functions
- */
-void acpi_ut_convert_string_to_uuid(char *in_string, u8 *uuid_buffer);
-
 #endif				/* _ACUTILS_H */
diff --git a/drivers/acpi/acpica/utuuid.c b/drivers/acpi/acpica/utuuid.c
index 4dc3313..a829c74 100644
--- a/drivers/acpi/acpica/utuuid.c
+++ b/drivers/acpi/acpica/utuuid.c
@@ -65,32 +65,3 @@ ACPI_MODULE_NAME("utuuid")
 const u8 acpi_gbl_map_to_uuid_offset[UUID_BUFFER_LENGTH] = {
 	6, 4, 2, 0, 11, 9, 16, 14, 19, 21, 24, 26, 28, 30, 32, 34
 };
-
-/*******************************************************************************
- *
- * FUNCTION:    acpi_ut_convert_string_to_uuid
- *
- * PARAMETERS:  in_string           - 36-byte formatted UUID string
- *              uuid_buffer         - Where the 16-byte UUID buffer is returned
- *
- * RETURN:      None. Output data is returned in the uuid_buffer
- *
- * DESCRIPTION: Convert a 36-byte formatted UUID string to 16-byte UUID buffer
- *
- ******************************************************************************/
-
-void acpi_ut_convert_string_to_uuid(char *in_string, u8 *uuid_buffer)
-{
-	u32 i;
-
-	for (i = 0; i < UUID_BUFFER_LENGTH; i++) {
-		uuid_buffer[i] =
-		    (acpi_ut_ascii_char_to_hex
-		     (in_string[acpi_gbl_map_to_uuid_offset[i]]) << 4);
-
-		uuid_buffer[i] |=
-		    acpi_ut_ascii_char_to_hex(in_string
-					      [acpi_gbl_map_to_uuid_offset[i] +
-					       1]);
-	}
-}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ