linux-kernel - Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Jan 2015 10:06:55 +0000
From:	Lorenzo Stoakes <lstoakes@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org,
	Ana Rey <anarey@...il.com>, mcgrof@...not-panic.com,
	tapaswenipathak@...il.com, Rui Silva <rmfrfs@...il.com>,
	Jiayi Ye <yejiayily@...il.com>,
	Greg Donald <gdonald@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On 1 January 2015 at 06:28, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

>> > i may be wrong, but looks like you are doing many different things in the patch, not just whitespace errors.
>> > marked a few, please see inline -
...
> sorry for not trimming that. I noticed the big size while sending, but at that time the damage has already been done.
> but is it ok if we mention one thing in the commit log and do other things also? shouldn't we atleast mention that in the commit?

Hi Sudip,

I felt that 'additionally it removes inconsistent whitespace
throughout.' covered these cases, given there's a lot I also felt it'd
be more irritating for the community to receive several separate
patches for each individual *sub* type of whitespace removal beyond
those fixing checkpatch.pl messages, of course that kind of separation
could get pretty big and these patches are already big enough as it is
(this file had a lot of issues :)

As someone who's new to kernel development I'd be more than happy to
adjust this if the consensus is towards a different approach, however
I feel this is the least painful means of doing this particular patch
set.

Best, Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/