linux-kernel - Re: [PATCH] arch: mips: pci: pci-ip27.c: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Jan 2015 11:16:15 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	Ralf Baechle <ralf@...ux-mips.org>,
	John Crispin <blogic@...nwrt.org>, <linux-mips@...ux-mips.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch: mips: pci: pci-ip27.c:  Remove unused function

[[PATCH] arch: mips: pci: pci-ip27.c:  Remove unused function] On 01/01/2015 (Thu 16:32) Rickard Strandqvist wrote:

> Remove the function pci_enable_swapping() that is not used anywhere.

A quick search shows it has been orphanware since the git epoch (~2005)
so removing it should be fine AFAICT.

P.
--

> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/mips/pci/pci-ip27.c |   11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci-ip27.c
> index 0f09eaf..55e3332 100644
> --- a/arch/mips/pci/pci-ip27.c
> +++ b/arch/mips/pci/pci-ip27.c
> @@ -200,17 +200,6 @@ static inline void pci_disable_swapping(struct pci_dev *dev)
>  	bridge->b_widget.w_tflush;	/* Flush */
>  }
>  
> -static inline void pci_enable_swapping(struct pci_dev *dev)
> -{
> -	struct bridge_controller *bc = BRIDGE_CONTROLLER(dev->bus);
> -	bridge_t *bridge = bc->base;
> -	int slot = PCI_SLOT(dev->devfn);
> -
> -	/* Turn on byte swapping */
> -	bridge->b_device[slot].reg |= BRIDGE_DEV_SWAP_DIR;
> -	bridge->b_widget.w_tflush;	/* Flush */
> -}
> -
>  static void pci_fixup_ioc3(struct pci_dev *d)
>  {
>  	pci_disable_swapping(d);
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/