linux-kernel - Re: [PATCH v7 2/4] fpga manager: add sysfs interface document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Jan 2015 12:50:10 +0200
From:	Pantelis Antoniou <pantelis.antoniou@...sulko.com>
To:	Pavel Machek <pavel@...x.de>
Cc:	atull <atull@...nsource.altera.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	jgunthorpe@...idianresearch.com, hpa@...or.com,
	Michal Simek <monstr@...str.eu>,
	Michal Simek <michal.simek@...inx.com>, rdunlap@...radead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	robh+dt@...nel.org, grant.likely@...aro.org, iws@...o.caltech.edu,
	linux-doc@...r.kernel.org, broonie@...nel.org, philip@...ister.org,
	rubini@...dd.com, s.trumtrar@...gutronix.de, jason@...edaemon.net,
	kyle.teske@...com, nico@...aro.org, balbi@...com,
	m.chehab@...sung.com, davidb@...eaurora.org, rob@...dley.net,
	davem@...emloft.net, cesarb@...arb.net, sameo@...ux.intel.com,
	akpm@...ux-foundation.org, linus.walleij@...aro.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	devel@...verdev.osuosl.org, delicious.quinoa@...il.com,
	dinguyen@...nsource.altera.com, yvanderv@...nsource.altera.com
Subject: Re: [PATCH v7 2/4] fpga manager: add sysfs interface document

Hi Pavel,

> On Jan 2, 2015, at 07:12 , Pavel Machek <pavel@...x.de> wrote:
> 
> 
>> +What:		/sys/class/fpga_manager/<fpga>/firmware
>> +Date:		October 2014
>> +KernelVersion:	3.18
>> +Contact:	Alan Tull <atull@...nsource.altera.com>
>> +Description:	Name of the FPGA image file to load using firmware class.
> 
> This is wrong interface, right? The only use of this string is to pass
> it to udev. We should simply pass "fpga-0" as a firware name, and let
> udev figure it out, no need to to prepare name in separate component,
> then pass it to kernel, which passes it back to udev.
> 

No. No dependencies on udev please. This should hook directly to the firmware
loader interface which does not rely on userspace at all.

>> +What:		/sys/class/fpga_manager/<fpga>/reset
>> +Date:		October 2014
>> +KernelVersion:	3.18
>> +Contact:	Alan Tull <atull@...nsource.altera.com>
>> +Description:	Write 1 to reset the FPGA
> 
> Does 0 need to be written there to pull the fpga out of reset? Is this
> a suitable interface?
> 
> 								Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Regards

— Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/