linux-kernel - Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Jan 2015 05:38:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	nizamhaider786@...il.com, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

On Mon, 2015-01-05 at 13:30 +0000, Mark Brown wrote:
> On Mon, Jan 05, 2015 at 04:36:03AM -0800, Joe Perches wrote:
> > On Mon, 2015-01-05 at 17:31 +0530, nizamhaider786@...il.com wrote:
> > > From: Nizam Haider <nizamhaider786@...il.com>
> 
> > > fixed a coding style issue
> 
> > This is a checkpatch defect and not a coding styple (style) issue.
> 
> > Please don't blindly take checkpatch messages as dicta.
> 
> No, it's a coding style thing.

It's a coding style consistency thing.

> It may have been identified by
> checkpatch but that's what it is.

__pure is a #define for a gcc attribute

include/linux/compiler-gcc.h:#define __pure                             __attribute__((pure))

macro attributes are almost always used
with space separators in the kernel.

All instances of __pure in the kernel have
a space before the use.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/