lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 05 Jan 2015 15:22:01 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	David Rientjes <rientjes@...gle.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>,
	Minchan Kim <minchan@...nel.org>,
	Rik van Riel <riel@...hat.com>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Subject: Re: [PATCH V3 0/4] Reducing parameters of alloc_pages* family of
 functions

On 12/18/2014 10:26 PM, Andrew Morton wrote:
> On Fri, 12 Dec 2014 17:13:21 +0100 Vlastimil Babka <vbabka@...e.cz> wrote:
> 
>> Vlastimil Babka (4):
>>   mm: set page->pfmemalloc in prep_new_page()
>>   mm, page_alloc: reduce number of alloc_pages* functions' parameters
>>   mm: reduce try_to_compact_pages parameters
>>   mm: microoptimize zonelist operations
> 
> That all looks pretty straightforward.  It would be nice to have a
> summary of the code-size and stack-usage changes for the whole
> patchset.

OK

> Can we move `struct alloc_context' into mm/internal.h?

Only if we moved also try_to_compact_pages() declaration from
include/linux/compaction.h to mm/internal.h. I guess it's not a bad idea, as
it's a MM-only function and mm/internal.h already contains compaction stuff.

> I pity the poor schmuck who has to maintain this patchset for 2 months.
> [2/4] already throws a large pile of rejects against page_alloc.c so
> can you please refresh/retest/resend?

Right :)

Vlastimil


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ