linux-kernel - Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Jan 2015 10:08:37 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Piotr Kubus <p.t.kubus@...il.com>
CC:	Konrad Zapalowicz <bergo.torino@...il.com>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

On 06/01/15 06:02, Sudip Mukherjee wrote:
> On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
>> On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
>>> On 01/04, Piotr Kubus wrote:
>>>> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
>>>
>>> Nice however improve your commit message. The rule is that the lines
>>> should wrap at 72nd column except for quoted material such as compiler
>>> output, etc...
>>>
>>> The 72-character columns are important for allowing quoting and they
>>> play nicely with standard indentation from git log.
>>
>> Hey,
>>
>> I couldn't find that rule in Kernel documentation. Besides there were no
>> complaints from checkpatch.pl tool.
>
> Please check SubmittingPatches in Documentation. It says:
> 'the "summary" must be no more than 70-75 characters'

In this case, it's not the "summary" that's at issue, it's the body of 
the commit message, as Konrad mentioned above.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/