linux-kernel - Re: [PATCH] spi: orion: Add multiple chip select support for Armada 370 and 375

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2015 22:47:56 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Ken Wilson <ken.wilson@...ngear.com>
Cc:	robh+dt@...nel.org, mark.rutland@....com,
	devicetree@...r.kernel.org, linux@....linux.org.uk,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	gerg@...inux.org, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, broonie@...nel.org,
	ezequiel.garcia@...e-electrons.com, galak@...eaurora.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] spi: orion: Add multiple chip select support for Armada
 370 and 375

Hi Ken

> -static const struct orion_spi_dev armada_spi_dev_data = {
> +static const struct orion_spi_dev armada_370_spi_dev_data = {
>  	.typ = ARMADA_SPI,
>  	.min_divisor = 1,
>  	.max_divisor = 1920,
>  	.prescale_mask = ARMADA_SPI_CLK_PRESCALE_MASK,
> +	.num_cs = 4,
> +};
> +
> +static const struct orion_spi_dev armada_375_spi_dev_data = {
> +	.typ = ORION_SPI,
> +	.min_divisor = 4,
> +	.max_divisor = 30,
> +	.prescale_mask = ORION_SPI_CLK_PRESCALE_MASK,
> +	.num_cs = 3,
>  };

Documentation/devicetree/bindings/spi/spi-bus.txt has the optional property:

- num-cs : total number of chipselects

Would it be better to use that?

      Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/