linux-kernel - Re: [PATCH V3 0/4] Reducing parameters of alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2015 20:53:19 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	David Rientjes <rientjes@...gle.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>,
	Minchan Kim <minchan@...nel.org>,
	Rik van Riel <riel@...hat.com>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Subject: Re: [PATCH V3 0/4] Reducing parameters of alloc_pages* family of functions

On Mon, Jan 5, 2015 at 8:01 AM, Vlastimil Babka <vbabka@...e.cz> wrote:
>
> Hm, nope. The !CONFIG_COMPACTION variant of try_to_compact_pages() is static
> inline that returns COMPACT_CONTINUE, which is defined in compaction.h.
> Another solution is to add a "forward" declaration (not actually followed later
> by a full definition) of struct alloc_context into compaction.h. Seems to work
> here, but I'm not sure if such thing is allowed?

We do forward struct declarations quite often (well, _relatively_
often) in order to avoid nasty circular header includes, and sometimes
just to avoid unnecessarily many header includes.

See for example

    git grep '\<struct [a-zA-Z_0-9]*;'

it's not exactly rare.

So it's fine.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/