linux-kernel - Re: [PATCH 3/6] btwilink: add minimal device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Jan 2015 23:07:01 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Gigi Joseph <gigi.joseph@...il.com>
Cc:	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	BlueZ development <linux-bluetooth@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	devicetree@...r.kernel.org, Gigi Joseph <gigi.joseph@...com>,
	Eyal Reizer <eyalr@...com>, bvijay <bvijay@...com>
Subject: Re: [PATCH 3/6] btwilink: add minimal device tree support

Hi Gigi,

> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
> 
> Signed-off-by: Eyal Reizer <eyalr@...com>
> Signed-off-by: bvijay <bvijay@...com>
> Signed-off-by: Gigi Joseph <gigi.joseph@...com>
> ---
> drivers/bluetooth/btwilink.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
> 
> #include <linux/ti_wilink_st.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> 
> /* Bluetooth Driver Version */
> #define VERSION               "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
> 	return 0;
> }
> 
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> +	.compatible = "btwilink",
> +	},
> +	{}
> +};

this formatting is bogus. Please construct it similar to what other drivers are doing.

static const struct .. = {
	{ .compatible = ".." },

	{ }	/* Terminating entry */
};

And add an extra empty line before MODULE_DEVICE_TABLE.

> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
> static int bt_ti_probe(struct platform_device *pdev)
> {
> 	static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
> 	.remove = bt_ti_remove,
> 	.driver = {
> 		.name = "btwilink",
> +		.owner = THIS_MODULE,
> +		.of_match_table = of_match_ptr(btwilink_of_match),
> 	},
> };

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/