lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Jan 2015 11:12:00 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Michael Schmitz <schmitzmic@...il.com> Cc: linux-m68k <linux-m68k@...ts.linux-m68k.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] m68k/atari: Remove obsolete keyboard_tasklet scheduling Hi Michael, On Sun, Aug 31, 2014 at 11:16 AM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote: > On Sun, Aug 31, 2014 at 11:07 AM, Michael Schmitz <schmitzmic@...il.com> wrote: >>> If CONFIG_VT=n: >>> >>> arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt': >>> atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet' >>> atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet' >> >> Has keyboard_tasklet gone for good, or just been conditionalized on >> CONFIG_VT? > > Conditionalized. It's in drivers/tty/vt/keyboard.c. > Note that this was from a randconfig build. > >>> I think the keyboard_tasklet scheduling is no longer needed, as I >>> believe it's handled by drivers/tty/vt/keyboard.c based on events >>> received from the input subsystem. So just remove it. >> >> I'd like to test this on real hardware (though ARAnyM does emulate the >> keyboard ACIA IIRC - if you had a working keyboard there I should find no >> different), > > Keyboard was still working on ARAnyM. > But AFAICU, the keyboard_tasklet is used for the LED state only. Did you manage to test this on real hardware? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists