linux-kernel - Re: [PATCHv2 2/2] ALSA: log emu8000 DRAM size at level INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 11 Jan 2015 11:53:40 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	David Flater <vger@...terco.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	Alsa Devel <alsa-devel@...a-project.org>
Subject: Re: [PATCHv2 2/2] ALSA: log emu8000 DRAM size at level INFO

At Fri, 09 Jan 2015 19:51:47 -0500,
David Flater wrote:
> 
> Applicable after PATCHv2 1/2:
> 
> Detected sound font memory goes unreported unless the kernel was built with
> ALSA debugging enabled.  Elevate that to a printk at level INFO.

Nowadays we'd like to avoid use of snd_print*().  Let's use a standard
macro, either dev_info() or pr_info(), instead.


thanks,

Takashi


> 
> Signed-off-by: David Flater <dave@...terco.com>
> ---
> History:
> 2015-01-09  v2: In response to feedback from Takashi Iwai,
>                1. Optimize for diff size.
>                  1a. Use goto to avoid indenting.
>                  1b. Jettison new debugging printouts.
>                2. Split printk into second patch.
>             Retested on CT4390 (4 MiB) and CT4380 (512 KiB).
> 2015-01-08  v1 patch sent to LKML, Alsa Devel and maintainers.  Tested on
>             unexpanded CT4390 (4 MiB), CT4520 (512 KiB), and CT4380 (512
>             KiB).
> 
>  sound/isa/sb/emu8000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/isa/sb/emu8000.c b/sound/isa/sb/emu8000.c
> index 3dcf80e..7429a51 100644
> --- a/sound/isa/sb/emu8000.c
> +++ b/sound/isa/sb/emu8000.c
> @@ -451,7 +451,7 @@ size_dram(struct snd_emu8000 *emu)
>  	snd_emu8000_dma_chan(emu, 0, EMU8000_RAM_CLOSE);
>  	snd_emu8000_dma_chan(emu, 1, EMU8000_RAM_CLOSE);
>  
> -	snd_printdd("EMU8000 [0x%lx]: %d Kb on-board memory detected\n",
> +	snd_printk(KERN_INFO "EMU8000 [0x%lx]: %d KiB on-board DRAM detected\n",
>  		    emu->port1, size/1024);
>  
>  	emu->mem_size = size;
> -- 
> 1.8.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/