linux-kernel - Re: [PATCH 10/10] PCI, sparc: clip firmware assigned resource under parent bridge's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2015 23:31:09 +0100
From:	Kjetil Oftedal <oftedal@...il.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Yijing Wang <wangyijing@...wei.com>,
	Sam Ravnborg <sam@...nborg.org>, sparclinux@...r.kernel.org
Subject: Re: [PATCH 10/10] PCI, sparc: clip firmware assigned resource under
 parent bridge's

Hi,

Am I missing something or is this just code to get the the resource
subsystem to accept the bus resources, not caring if the resources are
actually usable? PCI BARs usually have a given size for a reason?

-
Kjetil Oftedal


On 12/01/2015, Yinghai Lu <yinghai@...nel.org> wrote:
> Some bios put range that is not fully coverred by root bus resources.
> Try to clip them and update them in pci bridge bars.
>
> We'd like to fix other arches instead of just x86.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=85491
> Reported-by: Marek Kordik <kordikmarek@...il.com>
> Fixes: 5b28541552ef ("PCI: Restrict 64-bit prefetchable bridge windows to
> 64-bit resources")
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Yijing Wang <wangyijing@...wei.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: sparclinux@...r.kernel.org
> ---
>  arch/sparc/kernel/pci.c | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c
> index b36365f..0e391e5 100644
> --- a/arch/sparc/kernel/pci.c
> +++ b/arch/sparc/kernel/pci.c
> @@ -623,6 +623,7 @@ static void pci_claim_bus_resources(struct pci_bus
> *bus)
>  	struct pci_dev *dev;
>
>  	list_for_each_entry(dev, &bus->devices, bus_list) {
> +		bool changed = false;
>  		int i;
>
>  		for (i = 0; i < PCI_NUM_RESOURCES; i++) {
> @@ -639,8 +640,25 @@ static void pci_claim_bus_resources(struct pci_bus
> *bus)
>  				       (unsigned long long)r->end,
>  				       (unsigned int)r->flags);
>
> -			pci_claim_resource(dev, i);
> +			if (pci_claim_resource(dev, i) >= 0)
> +				continue;
> +
> +			if (dev->subordinate &&
> +			    i >= PCI_BRIDGE_RESOURCES &&
> +			    i < PCI_NUM_RESOURCES &&
> +			    (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI &&
> +			    pci_bus_clip_resource(dev, r)) {
> +				changed = true;
> +				pci_claim_resource(dev, i);
> +			} else if (i < PCI_BRIDGE_RESOURCES &&
> +				   i != PCI_ROM_RESOURCE &&
> +				   pci_bus_clip_resource(dev, r)) {
> +					pci_update_resource(dev, i);
> +					pci_claim_resource(dev, i);
> +			}
>  		}
> +		if (changed)
> +			pci_setup_bridge(dev->subordinate);
>  	}
>
>  	list_for_each_entry(child_bus, &bus->children, node)
> --
> 1.8.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/