linux-kernel - Re: [PATCH v9 07/12] coresight-etm: add CoreSight ETM/PTM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2015 08:05:31 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Pratik Patel <pratikp@...eaurora.org>,
	Vikas Varshney <varshney@...com>, Al Grant <Al.Grant@....com>,
	Jonas Svennebring <jonas.svennebring@...gotech.com>,
	James King <james.king@...aro.org>,
	Kaixu Xia <kaixu.xia@...aro.org>,
	Marcin Jabrzyk <marcin.jabrzyk@...il.com>,
	"r.sengupta@...sung.com" <r.sengupta@...sung.com>,
	trollkarlen Marklund <robbelibobban@...il.com>,
	Patch Tracking <patches@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 07/12] coresight-etm: add CoreSight ETM/PTM driver

On 12 January 2015 at 04:34, Paul Bolle <pebolle@...cali.nl> wrote:
> On Mon, 2014-11-10 at 20:32 +0100, Paul Bolle wrote:
>> On Mon, 2014-11-10 at 08:40 -0700, Mathieu Poirier wrote:
>> > On 10 November 2014 03:34, Paul Bolle <pebolle@...cali.nl> wrote:
>> > > On Mon, 2014-11-03 at 11:07 -0700, mathieu.poirier@...aro.org wrote:
>> > >> +#ifdef CONFIG_CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE
>> > >
>> > > There's no Kconfig symbol CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE. Neither
>> > > is there a preprocessor definition of this macro. So why was this
>> > > added?
>> >
>> > Correct - the feature (as we really want it) is currently being worked
>> > on but not yet part of the code base.  The default option probably
>> > should have been removed but it doesn't do much else when mandating
>> > one to add a boot option on the kernel cmd line.
>>
>> I'm afraid I'm not sure what you mean here. Anyhow, using a Kconfig
>> symbol to set a default for something that can also be set through a
>> kernel parameter might be considered overdoing it. But that's not for me
>> to decide.
>>
>> Unless the patch that adds this Kconfig symbol takes a long time to land
>> in linux-next, I won't be bothering you again.
>
> Two months have passed. This code made it unchanged into v3.19-rc1. A
> Kconfig symbol CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE is not yet part of
> linux-next.
>
> Should I submit a trivial patch to drop the useless check for
> CONFIG_CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE?

I thought the "boot time enabled" feature would come in before the new
year but things are less certain now - if you're kind enough to submit
a patch I'll take it.

>
>
> Paul Bolle
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/