linux-kernel - Re: [PATCH 5/7] perf tools: Pass struct perf_hpp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2015 13:21:40 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kan Liang <kan.liang@...el.com>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH 5/7] perf tools: Pass struct perf_hpp_fmt to its callbacks

Em Thu, Jan 08, 2015 at 09:45:46AM +0900, Namhyung Kim escreveu:
> Currently ->cmp, ->collapse and ->sort callbacks doesn't pass
> corresponding fmt.  But it'll be needed by upcoming changes in
> perf diff command.
> 
> Suggested-by: Jiri Olsa <jolsa@...nel.org>


  CC       /tmp/build/perf/builtin-evlist.o
builtin-diff.c: In function ‘data__hpp_register’:
builtin-diff.c:1036:11: error: assignment from incompatible pointer type [-Werror]
  fmt->cmp    = hist_entry__cmp_nop;
           ^
builtin-diff.c:1037:16: error: assignment from incompatible pointer type [-Werror]
  fmt->collapse = hist_entry__cmp_nop;
                ^
builtin-diff.c:1043:13: error: assignment from incompatible pointer type [-Werror]
   fmt->sort  = hist_entry__cmp_baseline;
             ^
builtin-diff.c:1047:13: error: assignment from incompatible pointer type [-Werror]
   fmt->sort  = hist_entry__cmp_delta;
             ^
builtin-diff.c:1051:13: error: assignment from incompatible pointer type [-Werror]
   fmt->sort  = hist_entry__cmp_ratio;
             ^
builtin-diff.c:1055:13: error: assignment from incompatible pointer type [-Werror]
   fmt->sort  = hist_entry__cmp_wdiff;
             ^
builtin-diff.c:1058:13: error: assignment from incompatible pointer type [-Werror]
   fmt->sort  = hist_entry__cmp_nop;
             ^
cc1: all warnings being treated as errors
  LINK     plugin_kvm.so
make[1]: *** [/tmp/build/perf/builtin-diff.o] Error 1
make[1]: *** Waiting for unfinished jobs....
  LINK     plugin_mac80211.so

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/