linux-kernel - Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2015 13:31:26 -0600
From:	Felipe Balbi <balbi@...com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	<balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	David Laight <David.Laight@...LAB.COM>
Subject: Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote:
> Hi Felipe,
> 
> On Mon, 12 Jan 2015 12:23:49 -0600
> Felipe Balbi <balbi@...com> wrote:
> 
> > On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote:
> > > at91sam9g45, at91sam9x5 and sama5 SoCs should not use
> > > "atmel,at91sam9rl-udc" for their USB device compatible property since
> > > this compatible is attached to a specific hardware bug fix.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > > Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > 
> > WARNING: DT compatible string "atmel,at91sam9g45-udc" appears un-documented -- check ./Documentation/devicetree/bindings/
> > #177: FILE: drivers/usb/gadget/udc/atmel_usba_udc.c:1827:
> > +       { .compatible = "atmel,at91sam9g45-udc" },
> > 
> > WARNING: DT compatible string "atmel,sama5d3-udc" appears un-documented -- check ./Documentation/devicetree/bindings/
> > #178: FILE: drivers/usb/gadget/udc/atmel_usba_udc.c:1828:
> > +       { .compatible = "atmel,sama5d3-udc" },
> > 
> > please fix and resend. Also, when resending, could you add Nicolas'
> > Acked-by since he's already given it ?
> 
> Actually these compatible strings are documented in the first patch
> (where they were introduced), but I'll send a v4 with Nicolas' ack.

heh, checkpatch stupidity :-) My bad.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)