linux-kernel - Re: [PATCH 2/2] irqchip: omap-intc: Remove unused legacy interface for omap2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 19:17:42 -0600
From:	Felipe Balbi <balbi@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 2/2] irqchip: omap-intc: Remove unused legacy interface
 for omap2

On Tue, Jan 13, 2015 at 02:23:26PM -0800, Tony Lindgren wrote:
> Nowadays omap2 is booting in device tree only mode so there is no
> need to keep the legacy interface around for omap2_init_irq().
> 
> Cc: Felipe Balbi <balbi@...com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Awesome, only one to go now.

Reviewed-by: Felipe Balbi <balbi@...com>
Acked-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/irqchip/irq-omap-intc.c       | 8 --------
>  include/linux/irqchip/irq-omap-intc.h | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c
> index b75a44a..ece8624 100644
> --- a/drivers/irqchip/irq-omap-intc.c
> +++ b/drivers/irqchip/irq-omap-intc.c
> @@ -348,14 +348,6 @@ out:
>  		omap_ack_irq(NULL);
>  }
>  
> -void __init omap2_init_irq(void)
> -{
> -	omap_nr_irqs = 96;
> -	omap_nr_pending = 3;
> -	omap_init_irq(OMAP24XX_IC_BASE, NULL);
> -	set_handle_irq(omap_intc_handle_irq);
> -}
> -
>  void __init omap3_init_irq(void)
>  {
>  	omap_nr_irqs = 96;
> diff --git a/include/linux/irqchip/irq-omap-intc.h b/include/linux/irqchip/irq-omap-intc.h
> index bda426a..2e3d1af 100644
> --- a/include/linux/irqchip/irq-omap-intc.h
> +++ b/include/linux/irqchip/irq-omap-intc.h
> @@ -18,7 +18,6 @@
>  #ifndef __INCLUDE_LINUX_IRQCHIP_IRQ_OMAP_INTC_H
>  #define __INCLUDE_LINUX_IRQCHIP_IRQ_OMAP_INTC_H
>  
> -void omap2_init_irq(void);
>  void omap3_init_irq(void);
>  
>  int omap_irq_pending(void);
> -- 
> 2.1.4
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)