linux-kernel - Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Jan 2015 16:04:08 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Oliver Neukum <oneukum@...e.de>
Cc:	曾婷葳 (tammy_tseng) <tammy_tseng@....com>,
	lkml <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	tammy0524@...il.com
Subject: Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

On Fri, Jan 16, 2015 at 5:11 AM, Oliver Neukum <oneukum@...e.de> wrote:
> On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote:
>> Hey, Oliver
>>
>> On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum <oneukum@...e.de> wrote:
>> On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote:
>> > > (Skip the code diff...)
>> >
>> > Again macros for endianness
>> >
>> > And the driver has a great number of conditional compilations are they
>> > really needed? The driver as is has a number of issues and is hard to
>> > review due to the use of "//" for comments and a lot of conditional
>> > compilation and unnecessary variables used for constants. Could you
>> > fix this up and resubmit?
>>
>> Thanks for the reply. I've modified the code (sis_i2c.c/sis_i2c.h/Kconfig/Makefile) to fix them.
>> Please help check them if anything needs to fix.
>
> Hi,
>
> I started from the lower end. I hope you find my comments
> useful. A few general points need to be made before the
> code is ready for review (it is obviously not ready for
> inclusion)

Also:

- it was sent as base64 so it can't be applied using normal tools
- it has DOS line endings
- even after decoding it does not apply
- dtor@...r-ws:~/kernel/work$ ./scripts/checkpatch.pl --no-signoff
sis-decoded.patch
...
total: 677 errors, 355 warnings, 1479 lines checked

Please make sure your code at least conforms to the kernel coding
style before resubmitting.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/