linux-kernel - Re: [PATCH 1/2] doc: Fix misnamed FUTEX_CMP_REQUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Jan 2015 17:55:09 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	Darren Hart <darren@...art.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] doc: Fix misnamed FUTEX_CMP_REQUEUE_PI 'op' constants

On Fri, Jan 16, 2015 at 08:27:57PM +0100, Michael Kerrisk (man-pages) wrote:
> From: Michael Kerrisk <mtk.manpages@...il.com>
> 
> FUTEX_CMP_REQUEUE_PI was misnamed in two different ways:
> FUTEX_REQUEUE_CMP_PI and FUTEX_REQUEUE_PI. The existence of two
> different misnamings leaves the reader wondering if we are talking
> about two different operations. Furthermore, the misnamings mean
> that grepping the source for the correct name (which doesn't
> appear at all) won't find this documentation file.
> 
> Signed-off-by: Michael Kerrisk <mtk.manpages@...il.com>

Ugh! I noticed this today while reviewing your futex manpage work. Embarassing
to say the least :/ Thanks Michael!

Reviewed-by: Darren Hart <dvhart@...ux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/