lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jan 2015 11:12:50 +0800 From: Yijing Wang <wangyijing@...wei.com> To: Arnd Bergmann <arnd@...db.de>, <linux-arm-kernel@...ts.infradead.org> CC: Bjorn Helgaas <bhelgaas@...gle.com>, Liviu Dudau <liviu@...au.co.uk>, "Tony Luck" <tony.luck@...el.com>, Russell King <linux@....linux.org.uk>, "Marc Zyngier" <marc.zyngier@....com>, <linux-pci@...r.kernel.org>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, <linux-m68k@...ts.linux-m68k.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, <linux-alpha@...r.kernel.org>, <linux-ia64@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "Guan Xuetao" <gxt@...c.pku.edu.cn>, Yinghai Lu <yinghai@...nel.org>, Jiang Liu <jiang.liu@...ux.intel.com> Subject: Re: [PATCH 10/28] PCI: Save sysdata in pci_host_bridge drvdata On 2015/1/16 17:18, Arnd Bergmann wrote: > On Friday 16 January 2015 09:44:08 Yijing Wang wrote: >> @@ -2066,11 +2064,11 @@ struct pci_bus *pci_scan_root_bus(struct device *parent, u32 db, >> { >> struct pci_host_bridge *host; >> >> - host = pci_create_host_bridge(parent, db, resources); >> + host = pci_create_host_bridge(parent, db, resources, sysdata); >> if (!host) >> return NULL; >> >> - return __pci_scan_root_bus(host, ops, sysdata); >> + return __pci_scan_root_bus(host, ops); >> } >> EXPORT_SYMBOL(pci_scan_root_bus); >> > > How about keeping the sysdata out of the pci_create_host_bridge interface, and > refactoring it so that the call sequence becomes > > host = pci_create_host_bridge(parent, db, resources); > host->sysdata = sysdata; > __pci_scan_root_bus(host, ops); > > This way, we can make sysdata completely option. I assume that more of the > fields we have in sysdata today can get moved into pci_host_bridge > over time, so a host bridge driver can just assign those members individually > between pci_create_host_bridge and __pci_scan_root_bus. I put the sysdata in pci_host_bridge, because some platforms x86/ia64 need to call pcibios_root_bridge_prepare() before pci_host_bridge registration in pci_create_host_bridge(), and pcibios_root_bridge_prepare() need the companion acpi device pointer which is stored in sysdata. I like you idea, but I haven't find a better way yet. Thanks! Yijing. > > Arnd > > . > -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists