linux-kernel - Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2015 09:00:16 +0800
From:	Bo Shen <voice.shen@...el.com>
To:	Peter Rosin <peda@...ator.liu.se>
CC:	Mark Brown <broonie@...nel.org>, <nicolas.ferre@...el.com>,
	<alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments

Hi Peter,

On 01/19/2015 09:54 PM, Peter Rosin wrote:
>> As the clock can be get from TK/RK pin, so remove the comments.
>>
>> Signed-off-by: Bo Shen <voice.shen@...el.com>
>> ---
>>   sound/soc/atmel/atmel_ssc_dai.c | 4 ----
>>   1 file changed, 4 deletions(-)
>> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
>> index e691aab..198661b 100644
>> --- a/sound/soc/atmel/atmel_ssc_dai.c
>> +++ b/sound/soc/atmel/atmel_ssc_dai.c
>> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>>   	case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM:
>>   		/*
>>   		 * I2S format, CODEC supplies BCLK and LRC clocks.
>> -		 *
>> -		 * The SSC transmit clock is obtained from the BCLK signal on
>> -		 * on the TK line, and the SSC receive clock is
>> -		 * generated from the transmit clock.
>>   		 */
>>   		rcmr =	  SSC_BF(RCMR_PERIOD, 0)
>>   			| SSC_BF(RCMR_STTDLY, START_DELAY)
>> --
>> 2.3.0.rc0
>
> Hi!
>
> You should probably remove that comment from the case with
> SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well...

Thanks, I will remove it in next version.

> Cheers,
> Peter
>

Best Regards,
Bo Shen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/