linux-kernel - Re: [PATCH] mmc: vub300: remove unreachable return value handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2015 12:36:05 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Nicholas Mc Guire <der.herr@...r.at>
Cc:	Tony Olech <tony.olech@...ndigitalsystems.com>,
	Chris Ball <chris@...ntf.net>,
	linux-mmc <linux-mmc@...r.kernel.org>, linux-usb@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: vub300: remove unreachable return value handling

On 18 January 2015 at 02:51, Nicholas Mc Guire <der.herr@...r.at> wrote:
> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>
> The return value of wait_for_completion_timeout is unsigned long,
> as it is used here for wait_for_completion_timeout only the type
> of commretval was changed to unsigned long.
>
> As wait_for_completion_timeout does not return negative values
> the commretval < 0 case is not reachable and can be removed.
>
> This was only compile-tested for x86_64_defconfig + CONFIG_MMC=m,
> CONFIG_MMC_VUB300=m
>
> Patch is against 3.19.0-rc4 -next-20150116
>
>  drivers/mmc/host/vub300.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 4262296..fbabbb8 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -659,7 +659,7 @@ static void __vub300_irqpoll_response(struct vub300_mmc_host *vub300)
>  static void __do_poll(struct vub300_mmc_host *vub300)
>  {
>         /* cmd_mutex is held by vub300_pollwork_thread */
> -       long commretval;
> +       unsigned long commretval;
>         mod_timer(&vub300->inactivity_timer, jiffies + HZ);
>         init_completion(&vub300->irqpoll_complete);
>         send_irqpoll(vub300);
> @@ -671,8 +671,6 @@ static void __do_poll(struct vub300_mmc_host *vub300)
>                 vub300->usb_timed_out = 1;
>                 usb_kill_urb(vub300->command_out_urb);
>                 usb_kill_urb(vub300->command_res_urb);
> -       } else if (commretval < 0) {
> -               vub300_queue_poll_work(vub300, 1);
>         } else { /* commretval > 0 */
>                 __vub300_irqpoll_response(vub300);
>         }
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/