linux-kernel - Re: [PATCH RESEND] fs: namei: Use memcpy instead of strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Jan 2015 19:44:44 -0500
From:	Paul Moore <paul@...l-moore.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Alexander Viro <viro@...iv.linux.org.uk>
CC:	Sabrina Dubroca <sd@...asysnail.net>,
	Paul Moore <pmoore@...hat.com>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] fs: namei: Use memcpy instead of strlcpy

Good point.  Do you mind if I merge your patch into my existing patch 
instead of including it separately?

--
paul moore
www.paul-moore.com



On January 21, 2015 5:45:29 PM Guenter Roeck <linux@...ck-us.net> wrote:

> If the string length is known, there is no need to use strlcpy.
> Use memcpy instead.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> Nitpick, but still a bit faster. Applies on top of -next.
>
> Resending with correct cc:. Sorry for the noise.
>
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 323957f..2e09219 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -233,7 +233,7 @@ getname_kernel(const char * filename)
>  		__putname(result);
>  		return ERR_PTR(-ENAMETOOLONG);
>  	}
> -	strlcpy((char *)result->name, filename, len);
> +	memcpy((char *)result->name, filename, len);
>  	result->uptr = NULL;
>  	result->aname = NULL;
>  	result->refcnt = 1;
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/