linux-kernel - Re: [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect type in assiggment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 Jan 2015 01:56:16 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"rydberg@...omail.se" <rydberg@...omail.se>,
	"bleung@...gle.com" <bleung@...gle.com>,
	"dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect
 type in assiggment

Dudley,

On Thu, Jan 22, 2015 at 09:57:42AM +0000, Dudley Du wrote:
> > -----Original Message-----
> > From: Jeremiah Mahler [mailto:jmmahler@...il.com]
> > Sent: 2015?1?22? 17:31
> > To: Dudley Du
[...]
> > >  struct gen5_bl_metadata_row_params {
> > >  __le16 size;
> > > -__le16 maximun_size;
> > > +__le16 maximum_size;
> > I don't think sparse cares about variable names.
> > Be sure to note these changes in your log.
> 
> This is a spell mistake issue, not sparse warning issue.
> Thanks.
> 
That is fine but just be sure to note that in the log.  I get suspicious
when there are changes that aren't mentioned in the log.

[...]
> > > +
> > > +if (app_integrity->flash_array_id != 0x00 ||
> > > +    get_unaligned_be16(&app_integrity->row_number) != 0x01ff) {
> > I could be wrong but it looks there are a lot of changes un-related to
> > the sparse warning.  I am not opposed to this per se but they should be
> > noted in the log message.
> 
> Understood.
> Indeed, excepted the spell error, the purpose of the changes are aimed to fix the warning issue.
> Do I need to add the log message and re-submit the patch or in other method ot change this?
> Thanks.
> 
Once I was able to reproduce the error there were quite a few.  So this
number of changes seems reasonable.

The fix is already in -next so I don't think it is a big enough problem
to worry about.

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/