linux-kernel - Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2015 07:11:18 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Feng Kan <fkan@....com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, patches <patches@....com>,
	jassisingbrar@...il.com, linux-i2c@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hieu Le <hnle@....com>
Subject: Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM
 X-Gene platform


> > ctx->dev is probably the wrong device here. The i2c controller is not
> > DMA capable itself, you need to have a pointer to the device that actually
> > performs the DMA here.
> 
> Arnd, I do agree this may not be the best identification. There is no
> representation for this on the Linux side. I could put it as NULL. However,
> there are other i2c bus drivers that seem to do the same thing. Please
> let me know what you think.

For completeness: Those drivers need fixing!

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)