linux-kernel - Re: [PATCH v4 0/2] fbcon: user-defined cursor blink interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2015 10:02:09 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Scot Doyle <lkml14@...tdoyle.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Richard Weinberger <richard.weinberger@...il.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 0/2] fbcon: user-defined cursor blink interval

On 27/01/15 01:09, Scot Doyle wrote:
> Since users prefer different fbcon cursor blink intervals, allow the
> interval to be set via sysfs. The current interval of 200 milliseconds
> is retained as the default. Tested with intelfb.
> 
> v2:  Use kstrtos16() instead of kstrtoul() and min_t() as suggested by
>      Geert Uytterhoeven
> v3:  Add error messages as suggested by Tomi Valkeinen

When I said "return an error" I did not mean "print an error message".
You should return an error code from the show and store functions when
something went wrong.

 Tomi




Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)