linux-kernel - Re: [BUG, bisect] hang when copying large file to disc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Feb 2015 11:30:13 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org
Subject: Re: [BUG, bisect] hang when copying large file to disc

Ted,

On Sat, Jan 31, 2015 at 09:02:30PM -0500, Theodore Ts'o wrote:
> On Fri, Jan 30, 2015 at 07:40:51PM -0800, Jeremiah Mahler wrote:
> > 
[...]
> 
> Thanks for the bug report.  I was able to reproduce the problem, and
> found the problem.  Unfortunately I accidentally introduce this in my
> most recent patchset.  I'll fix it up, but here is the patch until I
> get the a new version pushed out.
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 82c2984..0046861 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1192,9 +1192,9 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>  
>  		trace_writeback_dirty_inode(inode, flags);
>  	}
> -	dirtytime = flags & I_DIRTY_TIME;
>  	if (flags & I_DIRTY_INODE)
>  		flags &= ~I_DIRTY_TIME;
> +	dirtytime = flags & I_DIRTY_TIME;
>  
>  	/*
>  	 * Paired with smp_mb() in __writeback_single_inode() for the
> 
> 	   	       		   			      	  - Ted

That solved the problem.  Thanks for the quick fix.

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/