[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Feb 2015 12:16:01 +0000
From: Mark Brown <broonie@...nel.org>
To: Nicholas Mc Guire <hofrat@...dl.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] spi: ti-qspi: cleanup wait_for_completion return
handling
On Mon, Feb 02, 2015 at 03:30:36AM -0500, Nicholas Mc Guire wrote:
> - ret = wait_for_completion_timeout(&qspi->transfer_complete,
> - QSPI_COMPLETION_TIMEOUT);
> - if (ret == 0) {
> + if (!wait_for_completion_timeout(&qspi->transfer_complete,
> + QSPI_COMPLETION_TIMEOUT)) {
Same indentation issue as with the earlier patch here. I also just
noticed that you're not CCing driver maintainers, please try to do that
so they get a chance to review things.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists