linux-kernel - Re: [PATCH] x86/devicetree: Fix build for amd64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Feb 2015 00:14:14 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	David Vrabel <david.vrabel@...rix.com>,
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/devicetree: Fix build for amd64

Hi Ricardo,
	How about defining a version of apic_force_enable()
for X86_64 in apic.h which just return failure?
Regards!
Gerry

On 2015/2/2 23:50, Ricardo Ribalda Delgado wrote:
> apic_force_enable is not defined for amd64.
> 
> Without this patch:
> 
> LD      init/built-in.o
> arch/x86/built-in.o: In function `dtb_lapic_setup':
> kernel/devicetree.c:155:
> undefined reference to `apic_force_enable'
> Makefile:923: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  arch/x86/kernel/devicetree.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 3d35033..b5560de 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void)
>  
>  	/* Did the boot loader setup the local APIC ? */
>  	if (!cpu_has_apic) {
> +#ifndef CONFIG_X86_64
>  		if (apic_force_enable(r.start))
> +#endif
>  			return;
>  	}
>  	smp_found_config = 1;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/