linux-kernel - Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Feb 2015 21:05:50 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Antoine Schweitzer-Chaput <antoine@...weitzer-chaput.fr>,
	Ana Rey <anarey@...il.com>, Chaitanya Hazarey <c@...io>,
	Koray Gulcu <koray.gulcu@....edu.tr>,
	Greg Donald <gdonald@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null
 pointer dereference

2015-02-02 17:51 GMT+01:00 Sudip Mukherjee <sudipm.mukherjee@...il.com>:
> On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote:
>> Fix a possible null pointer dereference, there is
>> otherwise a risk of a possible null pointer dereference.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>  drivers/staging/rtl8192u/r8192U_core.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
>> index e031a25..4a29237 100644
>> --- a/drivers/staging/rtl8192u/r8192U_core.c
>> +++ b/drivers/staging/rtl8192u/r8192U_core.c
>> @@ -4476,11 +4476,11 @@ static void query_rxdesc_status(struct sk_buff *skb,
>>
>>       /* for debug 2008.5.29 */
>>
>> -     //added by vivi, for MP, 20080108
>> -     stats->RxIs40MHzPacket = driver_info->BW;
>> -     if (stats->RxDrvInfoSize != 0)
>> +     if (driver_info && stats->RxDrvInfoSize != 0) {
>> +             //added by vivi, for MP, 20080108
>> +             stats->RxIs40MHzPacket = driver_info->BW;
>>               TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
>> -
>> +     }
> but isn't the logic getting changed here?
>
> regards
> sudip
>
>>  }


Hi Sudip

Yes partly, but that's too ensure that driver_info is not null.

Se
call TranslateRxSignalStuff819xUsb()
->
call rtl8192_query_rxphystatus()

Where driver_info is pdrvinfo, and is used as:
  pdrvinfo->RxHT &&  pdrvinfo->RxRate
and more.

Or perhaps change in rtl8192_query_rxphystatus() instead?


Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/