linux-kernel - Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2015 13:45:43 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	balbi@...com
Cc:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pavel Machek <pavel@....cz>,
	Sebastian Reichel <sre@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Subject: Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

On Monday 02 February 2015 20:14:35 Felipe Balbi wrote:
> On Mon, Feb 02, 2015 at 08:07:51PM +0100, Pali Rohár wrote:
> > On Monday 02 February 2015 20:01:11 Felipe Balbi wrote:
> > > Hi,
> > > 
> > > On Mon, Feb 02, 2015 at 07:58:59PM +0100, Pali Rohár wrote:
> > > > On Monday 02 February 2015 19:54:58 Felipe Balbi wrote:
> > > > > Hi,
> > > > > 
> > > > > On Sat, Jan 31, 2015 at 10:53:30AM +0100, Pali Rohár 
wrote:
> > > > > > This patch adds removable mass storage support to
> > > > > > g_nokia gadget (for N900). It means that at runtime
> > > > > > block device can be exported or unexported. So it
> > > > > > does not export anything by default and thus allows
> > > > > > to use MyDocs partition as before...
> > > > > > 
> > > > > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > > > > 
> > > > > thanks, but no thanks. Build your own using configfs.
> > > > 
> > > > But it needs some userspace interaction right?
> > > > Then its not possible for nfsboot.
> > > 
> > > oh, right... you're using nfsboot through g_nokia. Hmm,
> > > sounds like you need initramfs.
> > 
> > Also compiling usb gadgets as external .ko modules is
> > broken. So I cannot use configfs, when I compile g_nokia
> > even if I use initramfs...
> 
> yeah, there are people working on that and some patches
> already flying around for it. Meanwhile, you can make it
> built-in and use initramfs to add mass_storage through
> configfs to g_nokia, no issues.

Sorry but nfsboot is used without initramfs. I do not need to use 
any initramfs and I do not see reason for it because of kernel 
usb bugs...

My patch for mass storage mode in g_nokia.ko driver (which is 
used for Nokia N900 only) fix usage of both g_nokia functions and 
mass storage functions.

Because in current state on N900 this is easy and *working* 
solution (g_nokia static linked into zImage). So I do not see 
reason why not to include my patch into upstream. Driver g_nokia 
is N900 specific and all developers can benefit this patch, 
because they would be able to use *both* usb networking and mass 
storage mode *without* need to recompile kernel and restart n900 
device!

And please do not tell me that either usb network or mass storage 
support is deprecated or so and nobody should not use it! This is 
only way how to develop & debug n900 device without any other 
Nokia (TM) equipment which is not available for non Nokias...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)