| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Feb 2015 21:44:24 +0000 From: Al Viro <viro@...IV.linux.org.uk> To: Steven Rostedt <rostedt@...dmis.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [RFC][PATCH 5/7] trace: make filter_parse_regex() provide the length of substring to compare with On Thu, Feb 05, 2015 at 04:29:33PM -0500, Steven Rostedt wrote: > On Thu, 5 Feb 2015 19:56:38 +0000 > Al Viro <viro@...IV.linux.org.uk> wrote: > > > From: Al Viro <viro@...iv.linux.org.uk> > > > > ... by passing len by address and using it to report the length of > > substring in question. > > You certainly are very verbose in your change logs. > > What exactly is the purpose of this patch? Clean up? Optimization? > > I can't really tell. Seems like you are just moving the strlen() from > outside the function into it. The point is that by now this strlen() is the only thing for which we NUL-termination of the substring; moving it inside the filter_parse_regex() is an obviously equivalent transformation and it leaves that one strlen() call inside filter_parse_regex() the only place where we still care about NUL. The next commit kills it off completely, at which point we are done with modifying the string at all. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists