linux-kernel - [PATCH] input: elan: Fix wrong %p extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri,  6 Feb 2015 14:51:13 +0100
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] input: elan: Fix wrong %p extension

There's no %px extension. From the context I think the intention was
to dump the five bytes which were not as expected, and for that one
should use %ph.

Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
---
I think the bug is mostly harmless, since the unrecognized extension
is simply ignored (and skipped over), and the address of the 'values'
array is simply printed as if by %5p. But since that is an address
on the kernel stack, someone might think it is worse than I do.

 drivers/input/mouse/elan_i2c_smbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index 359bf8583d54..2a89004f3c6e 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -71,7 +71,7 @@ static int elan_smbus_initialize(struct i2c_client *client)
 
 	/* compare hello packet */
 	if (memcmp(values, check, ETP_SMBUS_HELLOPACKET_LEN)) {
-		dev_err(&client->dev, "hello packet fail [%*px]\n",
+		dev_err(&client->dev, "hello packet fail [%*ph]\n",
 			ETP_SMBUS_HELLOPACKET_LEN, values);
 		return -ENXIO;
 	}
-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/