linux-kernel - Re: [PATCH v1 2/4] scsi: ufs: add debugfs for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Feb 2015 23:42:36 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Gilad Broner <gbroner@...eaurora.org>
Cc:	Jej B <James.Bottomley@...senpartnership.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, Santosh Y <santoshsy@...il.com>,
	linux-scsi-owner@...r.kernel.org,
	Subhash Jadavani <subhashj@...eaurora.org>,
	Yaniv Gardi <ygardi@...eaurora.org>,
	Dolev Raviv <draviv@...eaurora.org>,
	Lee Susman <lsusman@...eaurora.org>,
	Raviv Shvili <rshvili@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>
Subject: Re: [PATCH v1 2/4] scsi: ufs: add debugfs for ufs

2015-02-04 0:37 GMT+09:00 Gilad Broner <gbroner@...eaurora.org>:
> From: Lee Susman <lsusman@...eaurora.org>
>
> Adding debugfs capability for ufshcd.

...

> +void ufsdbg_add_debugfs(struct ufs_hba *hba)
> +{
> +       if (!hba) {
> +               pr_err("%s: NULL hba, exiting\n", __func__);
> +               return;
> +       }
> +
> +       hba->debugfs_files.debugfs_root = debugfs_create_dir("ufs", NULL);

This creates "ufs" directory in the root of debugfs.  So if there are
two or more UFS host controllers on a single system, only the first
one can succeed.  Should we append the index for unique directory
name for each contoroller like "ufs0", "ufs1", ...?

MMC debugfs support does something similar, it creates "mmc0"
directory in the root of debugfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/