linux-kernel - Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 8 Feb 2015 12:36:24 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	mchehab@....samsung.com, linux-media@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media:firewire:Remove unneeded function
 definition,avc_tuner_host2ca

On Feb 08 Nicholas Krause wrote:
> Removes the function,avc_tuner_host2ca and the ifdef marco statements
> around this function as there are no more callers of this function
> and therefor no need for it's definition anymore.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

Your changelog is incorrect.  If you had checked the history, you would
have learned that the function was added without callers in the first
place and never gained any callers since then.

How about first checking what the Host2CA AV/C command is for, and then
deciding on whether to add proper usage of it or to drop its implementation
from the source for good.

> ---
>  drivers/media/firewire/firedtv-avc.c | 31 -------------------------------
>  1 file changed, 31 deletions(-)
> 
> diff --git a/drivers/media/firewire/firedtv-avc.c b/drivers/media/firewire/firedtv-avc.c
> index 251a556..a7f2617 100644
> --- a/drivers/media/firewire/firedtv-avc.c
> +++ b/drivers/media/firewire/firedtv-avc.c
> @@ -912,37 +912,6 @@ void avc_remote_ctrl_work(struct work_struct *work)
>  	avc_register_remote_control(fdtv);
>  }
>  
> -#if 0 /* FIXME: unused */
> -int avc_tuner_host2ca(struct firedtv *fdtv)
> -{
> -	struct avc_command_frame *c = (void *)fdtv->avc_data;
> -	int ret;
> -
> -	mutex_lock(&fdtv->avc_mutex);
> -
> -	c->ctype   = AVC_CTYPE_CONTROL;
> -	c->subunit = AVC_SUBUNIT_TYPE_TUNER | fdtv->subunit;
> -	c->opcode  = AVC_OPCODE_VENDOR;
> -
> -	c->operand[0] = SFE_VENDOR_DE_COMPANYID_0;
> -	c->operand[1] = SFE_VENDOR_DE_COMPANYID_1;
> -	c->operand[2] = SFE_VENDOR_DE_COMPANYID_2;
> -	c->operand[3] = SFE_VENDOR_OPCODE_HOST2CA;
> -	c->operand[4] = 0; /* slot */
> -	c->operand[5] = SFE_VENDOR_TAG_CA_APPLICATION_INFO; /* ca tag */
> -	clear_operands(c, 6, 8);
> -
> -	fdtv->avc_data_length = 12;
> -	ret = avc_write(fdtv);
> -
> -	/* FIXME: check response code? */
> -
> -	mutex_unlock(&fdtv->avc_mutex);
> -
> -	return ret;
> -}
> -#endif
> -
>  static int get_ca_object_pos(struct avc_response_frame *r)
>  {
>  	int length = 1;



-- 
Stefan Richter
-=====-===== --=- -=---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/