lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Feb 2015 14:56:47 +0800 From: Addy <addy.ke@...k-chips.com> To: Ulf Hansson <ulf.hansson@...aro.org> CC: Rob Herring <robh+dt@...nel.org>, Paweł Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Randy Dunlap <rdunlap@...radead.org>, "tgih.jun@...sung.com" <tgih.jun@...sung.com>, Jaehoon Chung <jh80.chung@...sung.com>, Chris Ball <chris@...ntf.net>, Dinh Nguyen <dinguyen@...era.com>, Heiko Stübner <heiko@...ech.de>, Olof Johansson <olof@...om.net>, Doug Anderson <dianders@...omium.org>, Sonny Rao <sonnyrao@...omium.org>, Alexandru Stan <amstan@...omium.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-mmc <linux-mmc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, "zhenfu.fang" <zhenfu.fang@...k-chips.com>, Eddie Cai <cf@...k-chips.com>, lintao <lintao@...k-chips.com>, chenfen <chenfen@...k-chips.com>, zyf <zyf@...k-chips.com>, Jianqun Xu <xjq@...k-chips.com>, Tao Huang <huangtao@...k-chips.com>, Chris Zhong <zyw@...k-chips.com>, 姚智情 <yzq@...k-chips.com>, Han Jiang <hj@...k-chips.com>, Kever Yang <kever.yang@...k-chips.com>, zhangqing <zhangqing@...k-chips.com>, Lin Huang <hl@...k-chips.com> Subject: Re: [PATCH] mmc: dw_mmc: fix bug that cause 'Timeout sending command' On 2015.02.09 12:51, Ulf Hansson wrote: > On 5 February 2015 at 12:13, Addy Ke <addy.ke@...k-chips.com> wrote: >> Because of some uncertain factors, such as worse card or worse hardware, >> DAT[3:0](the data lines) may be pulled down by card, and mmc controller >> will be in busy state. This should not happend when mmc controller >> send command to update card clocks. If this happends, mci_send_cmd will >> be failed and we will get 'Timeout sending command', and then system will >> be blocked. To avoid this, we need reset mmc controller. >> >> Signed-off-by: Addy Ke <addy.ke@...k-chips.com> > > Hi Addy, > > Should I consider $subject patch as a better option to the one below? No: This patch fix the bug, which can be found by script: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 10000); do echo "========================" $i echo ff0c0000.dwmmc > unbind sleep .5 echo ff0c0000.dwmmc > bind sleep 2 done > [PATCH] mmc: dw_mmc: rockchip: Add DW_MCI_QUIRK_RETRY_DELAY This patch is for tuning issue: we should delay until card go to idle state, when the previous command return error. > https://lkml.org/lkml/2015/1/13/562 > > Kind regards > Uffe > > >> --- >> drivers/mmc/host/dw_mmc.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 4d2e3c2..b1d6dfb 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -100,6 +100,7 @@ struct idmac_desc { >> }; >> #endif /* CONFIG_MMC_DW_IDMAC */ >> >> +static int dw_mci_card_busy(struct mmc_host *mmc); >> static bool dw_mci_reset(struct dw_mci *host); >> static bool dw_mci_ctrl_reset(struct dw_mci *host, u32 reset); >> >> @@ -888,6 +889,26 @@ static void mci_send_cmd(struct dw_mci_slot *slot, u32 cmd, u32 arg) >> cmd, arg, cmd_status); >> } >> >> +static void dw_mci_wait_busy(struct dw_mci_slot *slot) >> +{ >> + struct dw_mci *host = slot->host; >> + unsigned long timeout = jiffies + msecs_to_jiffies(500); >> + >> + while (time_before(jiffies, timeout)) { >> + if (!dw_mci_card_busy(slot->mmc)) >> + return; >> + } >> + dev_err(host->dev, "Data busy (status %#x)\n", >> + mci_readl(slot->host, STATUS)); >> + >> + /* >> + * Data busy, this should not happend when mmc controller send command >> + * to update card clocks in non-volt-switch state. If it happends, we >> + * should reset controller to avoid getting "Timeout sending command". >> + */ >> + dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS); >> +} >> + >> static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit) >> { >> struct dw_mci *host = slot->host; >> @@ -899,6 +920,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit) >> /* We must continue to set bit 28 in CMD until the change is complete */ >> if (host->state == STATE_WAITING_CMD11_DONE) >> sdmmc_cmd_bits |= SDMMC_CMD_VOLT_SWITCH; >> + else >> + dw_mci_wait_busy(slot); >> >> if (!clock) { >> mci_writel(host, CLKENA, 0); >> -- >> 1.8.3.2 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@...r.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists