linux-kernel - Re: [PATCH V5 6/8] USB: f81232: clarify f81232

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2015 10:35:25 +0800
From:	Peter Hung <hpeter@...il.com>
To:	Johan Hovold <johan@...nel.org>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()

Hello,

Johan Hovold 於 2015/2/9 下午 04:42 寫道:

> The value you should be returning is
> jiffies_to_msecs(port->port.closing_wait) / 10, unless the value is
> ASYNC_CLOSING_WAIT_NONE in which case you simply return that, and
> similarly for close_delay.

I'll try to fix it, or reuse default value next version.

> Make sure to update the commit log for the next revision so that it
> describes what you actually do.
>
> I will probably not have time to review this version this week I'm
> afraid.

OK, I'll review it again, fix and resend it after Chinese New Year (2/23+).

Thanks all seniors.

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/