linux-kernel - [PATCH] mailbox, pl320-ipc: fixup return type of wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2015 05:25:45 -0500
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	linux-kernel@...r.kernel.org, Nicholas Mc Guire <hofrat@...dl.org>
Subject: [PATCH] mailbox, pl320-ipc: fixup return type of wait_for_completion_timeout

return type of wait_for_completion_timeout is unsigned long not int. A
appropriately named variable of type unsigned long is added and the
assignments fixed up.

Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
---

Patch was only compile tested with u300_defconfig + CONFIG_MAILBOX=y
CONFIG_PL320_MBOX=y

Patch is against 3.19.0 (localversion-next is -next-20150211)

 drivers/mailbox/pl320-ipc.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/pl320-ipc.c b/drivers/mailbox/pl320-ipc.c
index f3755e0..b898264 100644
--- a/drivers/mailbox/pl320-ipc.c
+++ b/drivers/mailbox/pl320-ipc.c
@@ -88,14 +88,15 @@ static u32 __ipc_rcv(int mbox, u32 *data)
 int pl320_ipc_transmit(u32 *data)
 {
 	int ret;
+	unsigned long time_left;
 
 	mutex_lock(&ipc_m1_lock);
 
 	init_completion(&ipc_completion);
 	__ipc_send(IPC_TX_MBOX, data);
-	ret = wait_for_completion_timeout(&ipc_completion,
+	time_left = wait_for_completion_timeout(&ipc_completion,
 					  msecs_to_jiffies(1000));
-	if (ret == 0) {
+	if (time_left == 0) {
 		ret = -ETIMEDOUT;
 		goto out;
 	}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/