lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 13 Feb 2015 13:57:20 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Tolga Ceylan <tolga.ceylan@...il.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style
 improvements

On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> 1) Lines over 80 characters were fixed
> 2) Alignment should match open paranthesis cases corrected
> 3) Comparison to NULL rewritten as !indio_dev

you are doing three different types of changes here. one patch should have only one type of change.

regards
sudip
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@...il.com>
> ---
>  drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++----------------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ