linux-kernel - Re: [PATCH] IIO: si7020: Allocate correct amount of memory in devm_iio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Feb 2015 11:36:56 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Andrey Smirnov <andrew.smirnov@...il.com>,
	linux-iio@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IIO: si7020: Allocate correct amount of memory in devm_iio_device_alloc

On 13/02/15 07:58, Andrey Smirnov wrote:
> Since only a pointer to struct i2c_client is stored in a private area
> of IIO device created by the driver there's no need to allocate
> sizeof(struct i2c_client) worth of storage.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
Applied to the fixes-togreg branch of iio.git.
Marked for stable to make sure this confusion doesn't arise
again!

Jonathan
> ---
>  drivers/iio/humidity/si7020.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/si7020.c b/drivers/iio/humidity/si7020.c
> index 69e49f5..fa3b809 100644
> --- a/drivers/iio/humidity/si7020.c
> +++ b/drivers/iio/humidity/si7020.c
> @@ -126,7 +126,7 @@ static int si7020_probe(struct i2c_client *client,
>  	/* Wait the maximum power-up time after software reset. */
>  	msleep(15);
> 
> -	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*client));
> +	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
>  	if (!indio_dev)
>  		return -ENOMEM;
> 
> --
> 2.1.0
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/