linux-kernel - Re: [PATCH 0/3 v2] Fix kdump failures with crashkernel=high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Feb 2015 17:11:35 +0100
From:	Joerg Roedel <joro@...tes.org>
To:	Baoquan He <bhe@...hat.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 0/3 v2] Fix kdump failures with crashkernel=high

Hi Baoquan,

On Sat, Feb 14, 2015 at 06:58:34PM +0800, Baoquan He wrote:
> This patch is very helpful and necessary since several users complained
> about the failure caused by not enough low mem. And the default value
> 256M is suitable since the testing data showed it's sufficient
> now and should be save for a long time.
>  
> And it also makes sense to supress the warning from buddy allocation
> failure which will call dump_stack in x86_swiotlb_alloc_coherent. Since
> it tried buddy allocation several times before the final try of bounce
> buffer allocation.
> 
> So ack the whole patch set.
> 
> Acked-by: Baoquan He <bhe@...hat.com> 

Thanks a lot!

> Hi Joerg,
> 
> Thanks for your effort on this issue. 
> 
> Could you please also update the cover letter or patch log to tell
> how 256M comes out with the later test result? I think it is convincing
> and helpful to understand.

Sure thing, will update the patch description before I resend the
series.


Regards,

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/