lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 18 Feb 2015 00:47:18 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] led/led-class: Handle LEDs with the same name

Hi

On Wed, Feb 18, 2015 at 12:35 AM, Bryan Wu <cooloney@...il.com> wrote:

> So why not use name "red0" and name another one "red1"? since you have
> multiple different red leds here any way.

I cannot control how many cameras the user will decide to attach to
the system, and if two similar cameras are attached to pciA and pciB,
they would try to load the same dt.

So I would have to parse the device tree on-line, finding the leds,
renaming them... and that code would be duplicated for every driver
doing similar work.  Not only that, I would have to avoid collisions
to my "cameras", also to other devices that may have decided to use
similar naming.

I think the proposed solution is more simple, and solves the issue of
duplicated led names around the whole system. Also, if there is no
duplicated names it follows the old behaviours.

Thanks!

>
> -Bryan
>> --
>> Ricardo Ribalda



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ